From 1611d82295136718d41a8a08f929293b096796b9 Mon Sep 17 00:00:00 2001
From: "github-actions[bot]"
 <41898282+github-actions[bot]@users.noreply.github.com>
Date: Mon, 4 Mar 2024 14:40:20 -0500
Subject: [PATCH] :bug: Adds spinner for isLoading prop in asessment status
 component (#1727) (#1734)

- Replaces erroneous not available status that is shown when no
assessments are available on an app

Signed-off-by: Ian Bolton <ibolton@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>

Signed-off-by: Ian Bolton <ibolton@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
Co-authored-by: Ian Bolton <ibolton@redhat.com>
---
 .../applications-table/applications-table.tsx          | 10 ++++++++--
 .../application-assessment-status.tsx                  |  8 ++++----
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/client/src/app/pages/applications/applications-table/applications-table.tsx b/client/src/app/pages/applications/applications-table/applications-table.tsx
index 8e776a4d3a..59412be6df 100644
--- a/client/src/app/pages/applications/applications-table/applications-table.tsx
+++ b/client/src/app/pages/applications/applications-table/applications-table.tsx
@@ -215,8 +215,9 @@ export const ApplicationsTable: React.FC = () => {
     refetch: fetchApplications,
   } = useFetchApplications();
 
-  const { assessments } = useFetchAssessments();
-  const { archetypes } = useFetchArchetypes();
+  const { assessments, isFetching: isFetchingAssesments } =
+    useFetchAssessments();
+  const { archetypes, isFetching: isFetchingArchetypes } = useFetchArchetypes();
 
   const onDeleteApplicationSuccess = (appIDCount: number) => {
     pushNotification({
@@ -915,6 +916,11 @@ export const ApplicationsTable: React.FC = () => {
                           application={application}
                           assessments={assessments}
                           archetypes={archetypes}
+                          isLoading={
+                            isFetchingApplications ||
+                            isFetchingArchetypes ||
+                            isFetchingAssesments
+                          }
                           key={`${application?.id}-assessment-status`}
                         />
                       </Td>
diff --git a/client/src/app/pages/applications/components/application-assessment-status/application-assessment-status.tsx b/client/src/app/pages/applications/components/application-assessment-status/application-assessment-status.tsx
index 8f2314f032..b6fba08f30 100644
--- a/client/src/app/pages/applications/components/application-assessment-status/application-assessment-status.tsx
+++ b/client/src/app/pages/applications/components/application-assessment-status/application-assessment-status.tsx
@@ -1,8 +1,8 @@
 import React from "react";
 import { useTranslation } from "react-i18next";
-import { EmptyTextMessage } from "@app/components/EmptyTextMessage";
 import { Application, Archetype, Assessment } from "@app/api/models";
 import { IconedStatus, IconedStatusPreset } from "@app/components/IconedStatus";
+import { Spinner } from "@patternfly/react-core";
 interface ApplicationAssessmentStatusProps {
   application: Application;
   assessments: Assessment[];
@@ -12,7 +12,7 @@ interface ApplicationAssessmentStatusProps {
 
 export const ApplicationAssessmentStatus: React.FC<
   ApplicationAssessmentStatusProps
-> = ({ application, assessments, archetypes }) => {
+> = ({ application, assessments, archetypes, isLoading }) => {
   const { t } = useTranslation();
 
   const filteredAssessments = assessments?.filter(
@@ -80,8 +80,8 @@ export const ApplicationAssessmentStatus: React.FC<
     };
   }, [archetypes, assessments]);
 
-  if (archetypes?.length === 0 || assessments?.length === 0) {
-    return <EmptyTextMessage message={t("terms.notAvailable")} />;
+  if (isLoading) {
+    return <Spinner size="sm" />;
   }
 
   let statusPreset: IconedStatusPreset = "NotStarted"; // Default status