108-eap6.windup.yaml

- category: mandatory
  customVariables: []
  description: Remote JNDI Provider URL has changed in EAP 7
  effort: 1
  labels:
  - konveyor.io/source=eap6
  - konveyor.io/source=eap
  - konveyor.io/target=eap7+
  - konveyor.io/target=eap
  - jndi
  - configuration
  - ejb
  links:
  - title: Remote JNDI URL in EAP 7
    url: https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/7.0/html-single/migration_guide/#migrate_default_remote_url_connector_and_port_changes
  message: |-
    Default Remote JNDI Provider URL has changed in EAP 7. External applications using JNDI to lookup remote resources, for instance an EJB or a JMS Queue,
     may need to change the value for the JNDI InitialContext environment's property named `java.naming.provider.url`.
     The default URL scheme is now **http-remoting** instead of **remote**, and the default URL port is now **8080** instead of **4447**.

     As an example, consider the application server host is localhost, then clients previously accessing EAP 6 would use

     ```
     java.naming.factory.initial=org.jboss.naming.remote.client.InitialContextFactory
     java.naming.provider.url=remote://localhost:4447
     ```

     while clients now accessing EAP 7 should use instead

     ```
     java.naming.factory.initial=org.jboss.naming.remote.client.InitialContextFactory
     java.naming.provider.url=http-remoting://localhost:8080
     ```
  ruleID: eap6-08000
  when:
    builtin.filecontent:
      filePattern: .*\.(java|properties|xml)
      pattern: remote://.*:\d*
- category: mandatory
  customVariables: []
  description: jboss-ejb-client.properties - Default Remote Connection Port changes
  effort: 1
  labels:
  - konveyor.io/source=eap6
  - konveyor.io/source=eap
  - konveyor.io/target=eap7+
  - konveyor.io/target=eap
  - jndi
  - configuration
  - ejb
  links:
  - title: Remote JNDI URL in EAP 7
    url: https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/7.0/html-single/migration_guide/#update_the_default_remote_connection_port
  message: |-
    The default remote connection port has changed in **jboss-ejb-client.properties** from '4447' to '8080'.

     In EAP 6, the jboss-ejb-client.properties file looked similar to the following:

     ```
     remote.connectionprovider.create.options.org.xnio.Options.SSL_ENABLED=false
     remote.connections=default
     remote.connection.default.host=localhost
     remote.connection.default.port=4447
     remote.connection.default.connect.options.org.xnio.Options.SASL_POLICY_NOANONYMOUS=false
     ```

     In EAP 7, the properties file looks like this:

     ```
     remote.connectionprovider.create.options.org.xnio.Options.SSL_ENABLED=false
     remote.connections=default
     remote.connection.default.host=localhost
     remote.connection.default.port=8080
     remote.connection.default.connect.options.org.xnio.Options.SASL_POLICY_NOANONYMOUS=false
     ```
  ruleID: eap6-08001
  when:
    builtin.filecontent:
      filePattern: jboss-ejb-client\.properties
      pattern: remote.connection..*.port(.*(?!8080)\d{4})
- category: mandatory
  customVariables: []
  description: Java - Default Remote Connection Port has changed in EAP 7
  effort: 1
  labels:
  - konveyor.io/source=eap6
  - konveyor.io/source=eap
  - konveyor.io/target=eap7+
  - konveyor.io/target=eap
  - jndi
  - configuration
  - ejb
  links:
  - title: Remote JNDI URL in EAP 7
    url: https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/7.0/html-single/migration_guide/#update_the_default_remote_connection_port
  message: |-
    The default remote connection port has changed from '4447' to '8080'.

     In EAP 6, Remote EJB client Java code looks like the following:

     ```java
     Properties properties = new Properties();
     properties.put("remote.connection.default.port", "4447");
     ```

     In EAP 7, the Java client code looks like this:

     ```java
     Properties properties = new Properties();
     properties.put("remote.connection.default.port", "8080");
     ```
  ruleID: eap6-08002
  when:
    builtin.filecontent:
      filePattern: .*\.java
      pattern: remote.connection..*.port(.*(?!8080)\d{4})
- category: mandatory
  customVariables: []
  description: JSF FaceletContext.FACELET_CONTEXT_KEY changed value
  effort: 1
  labels:
  - konveyor.io/source=eap6
  - konveyor.io/source=eap
  - konveyor.io/target=eap7+
  - konveyor.io/target=eap
  - jsf
  links:
  - title: Compatibility Issue Between JSF 2.1 and JSF 2.2
    url: https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/7.0/html-single/migration_guide/#compatibility_issue_between_jsf_2_1_and_jsf_2_2
  message: |-
    The value of JSF constant `FaceletContext.FACELET_CONTEXT_KEY` has changed between JSF 2.1 and 2.2.
     The variable is a compile-time constant expression, so when the program was originally compiled,
     the reference to `FACELET_CONTEXT_KEY` was replaced by its value during compilation.
     The application must be recompiled so that the reference to `FACELET_CONTEXT_KEY` is replaced by its new value.
  ruleID: eap6-11000
  when:
    or:
    - builtin.filecontent:
        filePattern: .*\.java
        pattern: com.sun.faces.facelets.FACELET_CONTEXT
    - builtin.filecontent:
        filePattern: .*\.java
        pattern: FaceletContext.FACELET_CONTEXT_KEY
- category: mandatory
  customVariables: []
  description: HTTPS URL hostname check against a service’s Common Name (CN) changed
  effort: 1
  labels:
  - konveyor.io/source=eap6
  - konveyor.io/source=eap
  - konveyor.io/target=eap7+
  - konveyor.io/target=eap
  - certificate
  - https
  links:
  - title: IgnoreHttpsHost CN Check Change
    url: https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/7.0/html-single/migration_guide/#changes_to_set_cookie_behavior
  message: In EAP 6, you could disable the HTTPS URL hostname check against a service’s
    Common Name (CN) given in its certificate by setting the system property `org.jboss.security.ignoreHttpsHost`
    to `true`. This system property name has been replaced with `cxf.tls-client.disableCNCheck`
    in EAP 7.
  ruleID: eap6-12000
  when:
    builtin.filecontent:
      filePattern: .*\.(java|properties|xml|cmd|sh|bat)
      pattern: org.jboss.security.ignoreHttpsHost