Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI active/inactive should be sent after complete XMPP handshake #1070

Closed
daniele-athome opened this issue Sep 24, 2017 · 0 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@daniele-athome
Copy link
Member

First of all, this is causing a crash:

java.lang.IllegalArgumentException: Client State Indication not supported by server
       at org.jivesoftware.smackx.csi.ClientStateIndicationManager.throwIaeIfNotSupported(ClientStateIndicationManager.java:46)
       at org.jivesoftware.smackx.csi.ClientStateIndicationManager.inactive(ClientStateIndicationManager.java:36)
       at org.kontalk.service.msgcenter.MessageCenterService.inactive(MessageCenterService.java:1664)
       at org.kontalk.service.msgcenter.MessageCenterService$IdleConnectionHandler.forceInactive(MessageCenterService.java:598)
       at org.kontalk.service.msgcenter.MessageCenterService$2.onReceive(MessageCenterService.java:630)

This can also lead to a packet being sent while handshaking SSL, which is bad.

@daniele-athome daniele-athome added the bug Something isn't working label Sep 24, 2017
@daniele-athome daniele-athome added this to the 4.1.0 milestone Sep 24, 2017
@daniele-athome daniele-athome self-assigned this Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant