Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Serial TRMM build #716

Merged
merged 2 commits into from
May 4, 2020
Merged

Fix Serial TRMM build #716

merged 2 commits into from
May 4, 2020

Conversation

brian-kelley
Copy link
Contributor

Fix typos in the complex and OpenMP+real test headers for SerialTRMM.
Running kokkos-dev2 spot check with double+complex_float, so that the code with the first issue is enabled.

Both real and complex test were including the "complex" header.
Caught by linker (multiple definitions of the complex tests)
@brian-kelley brian-kelley requested a review from e10harvey May 4, 2020 15:20
@brian-kelley brian-kelley self-assigned this May 4, 2020
@brian-kelley
Copy link
Contributor Author

Spot-check results:

#######################################################
PASSED TESTS 
#######################################################
clang-8.0-Pthread_Serial-release build_time=97 run_time=93
clang-9.0.0-Pthread-release build_time=75 run_time=46
clang-9.0.0-Serial-release build_time=71 run_time=46
gcc-4.8.4-OpenMP-release build_time=66 run_time=52
gcc-7.3.0-OpenMP-release build_time=83 run_time=51
gcc-7.3.0-Pthread-release build_time=79 run_time=47
gcc-8.3.0-Serial-release build_time=81 run_time=49
gcc-9.1-OpenMP-release build_time=101 run_time=51
gcc-9.1-Serial-release build_time=90 run_time=47
#######################################################
FAILED TESTS 
#######################################################
(All due to #715)
clang-8.0-Cuda_OpenMP-release (test failed)
cuda-10.1-Cuda_OpenMP-release (test failed)
cuda-9.2-Cuda_Serial-release (test failed)
intel-17.0.1-Serial-release (test failed)
intel-18.0.5-OpenMP-release (test failed)
intel-19.0.5-Pthread-release (test failed)

@brian-kelley brian-kelley merged commit 8c0fa7d into kokkos:develop May 4, 2020
@brian-kelley brian-kelley deleted the FixTrmm branch May 4, 2020 16:44
@e10harvey
Copy link
Contributor

Thank you, @brian-kelley! This must have been missed by the spot-checks on #697 due to the scalar type of float and device type.

@ndellingwood
Copy link
Contributor

@e10harvey the script only enables double by default, I'll put in a PR to add complex_double as well (complex_float tests are in a failing state until resolution of #715)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants