Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 168 #169

Merged
merged 2 commits into from
Mar 5, 2018
Merged

Issue 168 #169

merged 2 commits into from
Mar 5, 2018

Conversation

crtrott
Copy link
Member

@crtrott crtrott commented Mar 5, 2018

No description provided.

@crtrott
Copy link
Member Author

crtrott commented Mar 5, 2018

I will just merge this now. It fixes the OpenMP unit test failures on White in integration testing which were the only "new" failures:

    Start 1: MueLu_UnitTestsEpetra_kokkos_MPI_1
1/4 Test #1: MueLu_UnitTestsEpetra_kokkos_MPI_1 ...   Passed    1.39 sec
    Start 2: MueLu_UnitTestsEpetra_kokkos_MPI_4
2/4 Test #2: MueLu_UnitTestsEpetra_kokkos_MPI_4 ...   Passed    2.38 sec
    Start 3: MueLu_UnitTestsTpetra_kokkos_MPI_1
3/4 Test #3: MueLu_UnitTestsTpetra_kokkos_MPI_1 ...   Passed    1.30 sec
    Start 4: MueLu_UnitTestsTpetra_kokkos_MPI_4
4/4 Test #4: MueLu_UnitTestsTpetra_kokkos_MPI_4 ...   Passed    9.33 sec

100% tests passed, 0 tests failed out of 4

Label Time Summary:
MueLu    =  14.39 sec (4 tests)

Total Test time (real) =  14.43 sec

@crtrott crtrott merged commit 90a500a into develop Mar 5, 2018
ndellingwood
ndellingwood reviewed Mar 5, 2018
View reviewed changes
src/graph/KokkosGraph_graph_color.hpp
@@ -211,7 +211,14 @@ void d2_graph_color(
}

default:
{
color_view_type colors_out = color_view_type("Graph Colors", num_rows);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crtrott Just to check, Serial here refers strictly to the algorithms style of execution, the exec_space of the View does not need to be Kokkos::Serial?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah exactly.

@ndellingwood ndellingwood mentioned this pull request Mar 5, 2018
Closed
@ndellingwood
Copy link
Contributor

Cross-reference issue #168

@crtrott crtrott deleted the issue-168 branch November 6, 2018 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndellingwood ndellingwood ndellingwood left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crtrott @ndellingwood