Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the 'verbose' option consistent everywhere #911

Open
brian-kelley opened this issue Mar 10, 2021 · 0 comments
Open

Make the 'verbose' option consistent everywhere #911

brian-kelley opened this issue Mar 10, 2021 · 0 comments
Assignees
Labels
Cleanup Code maintenance that isn't a bugfix or new feature

Comments

@brian-kelley
Copy link
Contributor

The KokkosKernelsHandle has a bool option for verbose output that can be set with set_verbose(bool) and checked with get_verbose(). We should use this consistently throughout the library, instead of the macro VERBOSE. Right now, SpGEMM is using the general handle version. The SpTRSV handle has its own verbose flag, and Gauss-Seidel and D1/D2 coloring are using the macro. But all of these take the general handle so that flag is available.

For smaller/simpler features that don't use the handle, I don't think there's much need for enabling verbose output at runtime. We can just push detailed output for those things into the unit tests/perf tests.

@brian-kelley brian-kelley added the Cleanup Code maintenance that isn't a bugfix or new feature label Mar 10, 2021
@brian-kelley brian-kelley self-assigned this Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Code maintenance that isn't a bugfix or new feature
Projects
None yet
Development

No branches or pull requests

1 participant