Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set GOARM for older arm variants #235

Closed
mattmoor opened this issue Nov 2, 2020 · 1 comment · Fixed by #239
Closed

set GOARM for older arm variants #235

mattmoor opened this issue Nov 2, 2020 · 1 comment · Fixed by #239
Labels
bug Something isn't working

Comments

@mattmoor
Copy link
Collaborator

mattmoor commented Nov 2, 2020

Prior to aarch64 to build for arm variants you needed to set GOARCH=arm GOARM=v6 or whatnot.

I don't believe we currently set this, although I believe it appears in the platform info in the manifest list.

cc @jonjohnsonjr

I noticed this building a ko image on golang, which has many many variants.

@mattmoor mattmoor added the bug Something isn't working label Nov 2, 2020
@jonjohnsonjr
Copy link
Collaborator

jonjohnsonjr commented Nov 4, 2020

From https://golang.org/cmd/go/:

GOARM

For GOARCH=arm, the ARM architecture for which to compile.
	Valid values are 5, 6, 7.
$ crane manifest golang | jq .manifests[].platform.variant
2020/11/04 10:24:45 No matching credentials were found, falling back on anonymous
null
"v5"
"v7"
"v8"
null
null
null
null
null
null

Hate to see that v8. I guess we are going to hardcode a bunch of arm specific things.

Open issue that we can TODO: golang/go#29373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants