Merge bitcoin-core/gui#277: Do not use QClipboard::Selection on Windows and macOS.

MarcoFalke · knst · commit aa78e3df59e6 · 2023-11-30T14:36:33.000+07:00
7f3a598 qt: Do not use QClipboard::Selection on Windows and macOS. (Hennadii Stepanov) Pull request description: Windows and macOS do [not support](https://doc.qt.io/qt-5/qclipboard.html#notes-for-windows-and-macos-users) the global mouse selection. Fixes dashpay#258. ACKs for top commit: promag: Code review ACK 7f3a598. jarolrod: ACK 7f3a598 Tree-SHA512: be2beeef7d25af6f4d4a4548325d8d29f08e4342f499666bc4a670ed468a63195d514077c2cd0dba197e12bd43316fd3e2813cdc0954364b6aa4ae6b90c118bf
diff --git a/src/qt/guiutil.cpp b/src/qt/guiutil.cpp
@@ -1726,8 +1726,11 @@ void updateButtonGroupShortcuts(QButtonGroup* buttonGroup)
 
 void setClipboard(const QString& str)
 {
-    QApplication::clipboard()->setText(str, QClipboard::Clipboard);
-    QApplication::clipboard()->setText(str, QClipboard::Selection);
+    QClipboard* clipboard = QApplication::clipboard();
+    clipboard->setText(str, QClipboard::Clipboard);
+    if (clipboard->supportsSelection()) {
+        clipboard->setText(str, QClipboard::Selection);
+    }
 }
 
 fs::path qstringToBoostPath(const QString &path)

Original file line number	Diff line number	Diff line change
`@@ -1726,8 +1726,11 @@ void updateButtonGroupShortcuts(QButtonGroup* buttonGroup)`
`1726`	`1726`
`1727`	`1727`	`void setClipboard(const QString& str)`
`1728`	`1728`	`{`
`1729`		`- QApplication::clipboard()->setText(str, QClipboard::Clipboard);`
`1730`		`- QApplication::clipboard()->setText(str, QClipboard::Selection);`
	`1729`	`+ QClipboard* clipboard = QApplication::clipboard();`
	`1730`	`+ clipboard->setText(str, QClipboard::Clipboard);`
	`1731`	`+ if (clipboard->supportsSelection()) {`
	`1732`	`+ clipboard->setText(str, QClipboard::Selection);`
	`1733`	`+ }`
`1731`	`1734`	`}`
`1732`	`1735`
`1733`	`1736`	`fs::path qstringToBoostPath(const QString &path)`