Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not configure issuerRef, clusterLocalIssuerRef and systemInternalIssuerRef to distinct values. Fix attached #15433

Closed
mstein11 opened this issue Jul 31, 2024 · 0 comments · Fixed by #15434
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mstein11
Copy link
Contributor

What version of Knative?

1.15.0

Expected Behavior

When configuring cert manager, it should be possible to configure issuerRef, clusterLocalIssuerRef and systemInternalIssuerRef to three different configurations.

Actual Behavior

When setting one of issuerRef, clusterLocalIssuerRef and systemInternalIssuerRef in config-certmanager. All three get set to the same value. It is not possible to set distinct values for those fields.

Steps to Reproduce the Problem

Create knative serving configuration with the following:

apiVersion: operator.knative.dev/v1beta1
kind: KnativeServing
metadata:
  name: knative-serving
  namespace: knative-serving
spec:
  config:
    certmanager: 
      "issuerRef": |
        kind: ClusterIssuer
        name: letsencrypt-knative-prod
      "clusterLocalIssuerRef": |
        kind: ClusterIssuer
        name: knative-selfsigned-issuer
      "systemInternalIssuerRef": |
        kind: ClusterIssuer
        name: knative-selfsigned-issuer

Create a ksvc:

apiVersion: serving.knative.dev/v1
kind: Service
metadata:
  name: nginx-knative
  namespace: nginx-knative
spec:
  template:
    spec:
        - image: nginx
          ports:
            - containerPort: 80

The corresponding certificate will be of type knative-selfsigned-issuer.

Check the test case and bugfix in my fork as well: https://github.com/mstein11/knative-serving/tree/verify_bug_in_cert_manager_config

@mstein11 mstein11 added the kind/bug Categorizes issue or PR as related to a bug. label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant