Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go template dependencies are outdated #1460

Closed
matzew opened this issue Dec 7, 2022 · 8 comments
Closed

Go template dependencies are outdated #1460

matzew opened this issue Dec 7, 2022 · 8 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@matzew
Copy link
Member

matzew commented Dec 7, 2022

The go template uses some older dependencies, like:

  • Golang 1.14
  • Cloudevents SDK 2.5.0

See: https://github.com/knative/func/blob/main/templates/go/cloudevents/go.mod#L3-L5

Would it be reasonable to bump those to:

  • Golang 1.18
  • SDK 2.12
@lance
Copy link
Member

lance commented Dec 7, 2022

@matzew let's see how this PR plays out #1451 as it addresses that issue as well.

@ShlokMohanty
Copy link

@lance what's the update on this PR?

@ShlokMohanty
Copy link

if there is still a need for upgradation then we can label this issue as the good first issue?

@lance
Copy link
Member

lance commented Dec 12, 2022

if there is still a need for upgradation then we can label this issue as the good first issue?

@ShlokMohanty we are discussing some bigger changes to the Go templates in #1451 which would make this issue obsolete. I'd like to hold off for now on making any changes until we get the questions in 1451 resolved.

@ShlokMohanty
Copy link

@lance is the good first issue label removed from this issue ?

@lance
Copy link
Member

lance commented Jan 9, 2023

@lance is the good first issue label removed from this issue ?

Yes, mainly because these issues will likely be resolved in some form via #1451

@lkingland
Copy link
Member

Related: #1469

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants