Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better go module reflection of GOPATH #1459

Closed
matzew opened this issue Dec 7, 2022 · 5 comments
Closed

Better go module reflection of GOPATH #1459

matzew opened this issue Dec 7, 2022 · 5 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@matzew
Copy link
Member

matzew commented Dec 7, 2022

When creating a project, inside my $GOPATH, like:

func create -l go -t cloudevents      
Created go function in /home/matzew/go/src/github.com/matzew/payments

I was thinking that the go.mod, would reflect this a bit, and be like:

module github.com/matzew/payments

...

But instead it is a generic function module: https://github.com/knative/func/blob/main/templates/go/cloudevents/go.mod#L1

@lance
Copy link
Member

lance commented Dec 12, 2022

@matzew this is an artifact of the way Go functions are currently constructed. The template files which comprise main() are currently part of the buildpack, and expect a module named function.

https://github.com/boson-project/packs/blob/e8e1b3b08ac5599c71e999a52a0ff4c0432baa29/buildpacks/go/faas/main.go#L19

In #1451 I propose a path forward that removes this explicit dependency. (Also potentially in knative/community#1220 which would extract most of what's in #1451 into a new repository).

@matzew
Copy link
Member Author

matzew commented Dec 14, 2022

Ugh, that's quiet some disadvantage, thanks for sharing

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2023
@zroubalik
Copy link
Contributor

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants