Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow providing arbitrary HTTP headers for a uri style destination #5046

Closed
ctron opened this issue Mar 10, 2021 · 5 comments
Closed

Allow providing arbitrary HTTP headers for a uri style destination #5046

ctron opened this issue Mar 10, 2021 · 5 comments
Labels
area/delivery area/security kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@ctron
Copy link

ctron commented Mar 10, 2021

Problem

Using a uri as a destination (e.g. in a Sequence) the receiving endpoint might be secured and require additional information to allow access.

One way to achieve this may be a custom header, which currently cannot be presented as only a URI can be provided.

I guess the same is true when using a ref instead of a uri.

Persona:

Event consumer

Exit Criteria

Configure a Sequence with arbitrary additional HTTP headers, check that the receiving endpoint receives these.

Time Estimate (optional):

1

Additional context (optional)

@slinkydeveloper
Copy link
Contributor

slinkydeveloper commented Mar 10, 2021

Interesting, this might require to modify the Destination duck type... @vaikas @n3wscott @lionelvillard @grantr any thoughts?

@vaikas
Copy link
Contributor

vaikas commented Mar 10, 2021

I'd be down to define this more. When we were working on defining the Destination we did talk about some other things that we might want to bake in there, and one of the use cases was tokens. I not convinced however that we want to expand Destination to include a token (visible to anybody that can see the resources), but maybe a ref to a secret or something, but would be good to define couple of use cases for this and then figure out the best way to implement.

@lberk
Copy link
Member

lberk commented Mar 15, 2021

@ctron could you elaborate a bit more on the use-case so we can ensure any security requirements are properly met while integrating this into our apis?

@lberk lberk added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Mar 15, 2021
@lberk lberk added this to the Backlog milestone Mar 15, 2021
@ctron
Copy link
Author

ctron commented Mar 15, 2021

My concrete use case is Eclipse Ditto in "pre-authenticated" mode: https://www.eclipse.org/ditto/installation-operating.html#pre-authentication

That requires to set a custom header x-ditto-pre-authenticated, which proves that this user is special. All other ways into the system are expected to filter out this header.

I am pretty sure there are other use cases, providing standard or non-standard headers to influence the processing on the server side. Security related or not.

@lberk lberk added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Mar 29, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/delivery area/security kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

4 participants