Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track floating deps @ master #172

Merged
merged 3 commits into from
Jul 15, 2020
Merged

Track floating deps @ master #172

merged 3 commits into from
Jul 15, 2020

Conversation

tcnghia
Copy link
Contributor

@tcnghia tcnghia commented Jul 7, 2020

No description provided.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 7, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 7, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2020
mattmoor
mattmoor reviewed Jul 7, 2020
View reviewed changes
Copy link
Contributor

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 7, 2020
mattmoor
mattmoor reviewed Jul 7, 2020
View reviewed changes
Copy link
Contributor

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2020
@tcnghia
Copy link
Contributor Author

tcnghia commented Jul 15, 2020

/test pull-knative-net-istio-integration-tests

/test pull-knative-net-istio-latest

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@tcnghia
Copy link
Contributor Author

tcnghia commented Jul 15, 2020

Looks like legitimate test failures. I'm looking further.

@tcnghia
Copy link
Contributor Author

tcnghia commented Jul 15, 2020

/test pull-knative-net-istio-latest

mattmoor
mattmoor reviewed Jul 15, 2020
View reviewed changes
Copy link
Contributor

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
mattmoor
mattmoor reviewed Jul 15, 2020
View reviewed changes
Copy link
Contributor

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-net-istio-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/ingress/resources/virtual_service.go 95.9% 96.0% 0.1

@knative-prow-robot knative-prow-robot merged commit 3ac448b into knative-extensions:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@steuhs steuhs Awaiting requested review from steuhs

@yt3liu yt3liu Awaiting requested review from yt3liu

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tcnghia @knative-prow-robot @knative-metrics-robot @mattmoor @googlebot