diff --git a/lib/epubmaker/content.rb b/lib/epubmaker/content.rb index 4fee295d4..df0f4c8a2 100644 --- a/lib/epubmaker/content.rb +++ b/lib/epubmaker/content.rb @@ -39,7 +39,7 @@ def inspect # Construct Content object by passing a sequence of parameters or hash. # Keys of +hash+ relate with each parameters. # +file+ (or +hash+["file"]) is required. Others are optional. - def initialize(fileorhash, id = nil, media = nil, title = nil, level = nil, notoc = nil, properties = nil, chaptype = nil) + def initialize(fileorhash, id = nil, media = nil, title = nil, level = nil, notoc = nil, properties = nil, chaptype = nil) # rubocop:disable Metrics/ParameterLists if fileorhash.instance_of?(Hash) @id = fileorhash['id'] @file = fileorhash['file'] diff --git a/lib/review/epubmaker.rb b/lib/review/epubmaker.rb index 103c94023..6935a9f40 100644 --- a/lib/review/epubmaker.rb +++ b/lib/review/epubmaker.rb @@ -490,7 +490,7 @@ def push_contents(_basetmpdir) hash['id'] = args[:id] end if args[:properties].present? - hash['properties'] = args[:properties].split(' ') + hash['properties'] = args[:properties].split(' ') # rubocop:disable Style/RedundantArgument end if args[:notoc].present? hash['notoc'] = args[:notoc] diff --git a/lib/review/exception.rb b/lib/review/exception.rb index 91164fcff..ca0d781c9 100644 --- a/lib/review/exception.rb +++ b/lib/review/exception.rb @@ -10,10 +10,16 @@ module ReVIEW class Error < ::StandardError; end + class ApplicationError < Error; end + class ConfigError < ApplicationError; end + class CompileError < ApplicationError; end + class SyntaxError < CompileError; end + class FileNotFound < ApplicationError; end + class KeyError < CompileError; end end diff --git a/lib/review/latexutils.rb b/lib/review/latexutils.rb index fada74977..19126d6a5 100644 --- a/lib/review/latexutils.rb +++ b/lib/review/latexutils.rb @@ -59,7 +59,7 @@ def initialize_metachars(texcommand) end end - @metachars_re = /[#{Regexp.escape(@metachars.keys.join(''))}]/u + @metachars_re = /[#{Regexp.escape(@metachars.keys.join(''))}]/u # rubocop:disable Style/RedundantArgument @metachars_invert = @metachars.invert end diff --git a/review.gemspec b/review.gemspec index 5e67e5b90..a937d82f5 100644 --- a/review.gemspec +++ b/review.gemspec @@ -25,8 +25,9 @@ Gem::Specification.new do |gem| gem.add_dependency('rubyzip') gem.add_development_dependency('pygments.rb') gem.add_development_dependency('rake') - gem.add_development_dependency('rubocop', '~> 1.3.0') + gem.add_development_dependency('rubocop', '~> 1.6.0') gem.add_development_dependency('rubocop-performance') + gem.add_development_dependency('rubocop-rake') gem.add_development_dependency('simplecov') gem.add_development_dependency('test-unit') gem.add_development_dependency('unicode-eaw')