Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windowsでのreviewコマンド #940

Closed
kmuto opened this issue Feb 12, 2018 · 1 comment
Closed

Windowsでのreviewコマンド #940

kmuto opened this issue Feb 12, 2018 · 1 comment

Comments

@kmuto
Copy link
Owner

kmuto commented Feb 12, 2018

reviewコマンドの呼び出しは

exec(command_path, *ARGV)

となっているが、Windows環境だとexec先のshebangは使ってくれず、FORMAT Errorになる。
気乗りしないが

https://stackoverflow.com/questions/241341/for-ruby-webrick-i-need-windows-to-recognize-shebang-notation

あたりと同じロジックを入れて場合分け+rubyコマンドパスを生成とする必要がある？
@kmuto
Copy link
Owner Author

kmuto commented Feb 15, 2018

方針としてはやはりそれで合ってるらしい。
https://twitter.com/xingyanhuan/status/964087636737445888

@kmuto kmuto mentioned this issue Feb 16, 2018
Merged
@kmuto kmuto closed this as completed in 274d8e5 Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kmuto