Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MakerHelper: class -> module #582

Merged
merged 1 commit into from
Apr 21, 2016
Merged

MakerHelper: class -> module #582

merged 1 commit into from
Apr 21, 2016

Conversation

takahashim
Copy link
Collaborator

should be included by *Maker classes

should be included by *Maker classes
@takahashim
Copy link
Collaborator Author

ReVIEW::MakerHelperをクラスからモジュールに変えるものです。
現状はMakerHelper.copy_images_to_dirが1か所使われているだけだったので、module_functionで対応しています。これでテストの修正なしで通るはず。
最終的には、*Makerクラスでこのモジュールをincludeするようにして、メソッド実装を共有化する予定です。

@kmuto
Copy link
Owner

kmuto commented Apr 21, 2016

はい、とくに問題ないかと思います。

@takahashim takahashim merged commit ec37c10 into master Apr 21, 2016
@takahashim takahashim deleted the makerhelper_module branch April 21, 2016 04:49
@kdmsnr kdmsnr added this to the 2.0.0 milestone Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants