Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove method_statement from grammar #61

Closed
2 tasks
klauer opened this issue Apr 12, 2023 · 1 comment · Fixed by #63
Closed
2 tasks

Remove method_statement from grammar #61

klauer opened this issue Apr 12, 2023 · 1 comment · Fixed by #63
Labels
grammar maintenance Cleaning and maintenance

Comments

@klauer
Copy link
Owner

klauer commented Apr 12, 2023 •
edited
Loading

Looks like it's time to get rid of method_statement entirely.

function_call_statement (using function_call) handles everything it does and more, so having both just makes for ambiguity in the grammar.

Originally posted by @klauer in #59 (comment)

Checklist:

  • Remove method_statement from iec.lark
  • Remove MethodStatement from blark.transformers
@klauer klauer added grammar maintenance Cleaning and maintenance labels Apr 12, 2023
@engineerjoe440
Copy link
Collaborator

I actually had some questions about this, so this makes a lot of sense to me. Thank you for your attention to detail, here! 🎉

@engineerjoe440 engineerjoe440 mentioned this issue Apr 14, 2023
Merged
1 task
@klauer klauer linked a pull request Apr 19, 2023 that will close this issue
Address Issue with Array-Initialization -- Other General Cleanup #63
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
grammar maintenance Cleaning and maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address Issue with Array-Initialization -- Other General Cleanup engineerjoe440/blark
2 participants
@klauer @engineerjoe440