Skip to content
This repository was archived by the owner on Jan 8, 2025. It is now read-only.

dev: replace dojo SequencerConfig #1397

Closed
tcoratger opened this issue Sep 23, 2024 · 6 comments · Fixed by #1451
Closed

dev: replace dojo SequencerConfig #1397

tcoratger opened this issue Sep 23, 2024 · 6 comments · Fixed by #1451
Assignees
Labels
enhancement Enhancement of the code, not introducing new features. good first issue Good first issue for people wanting to contribute to this project.

Comments

@tcoratger
Copy link
Contributor

tcoratger commented Sep 23, 2024

To setup the Katana sequencer, we are using a SequencerConfig structure:

TestSequencer::start(SequencerConfig { no_mining: false, block_time: None }, katana_config()).await

But this structure is in the process of removal on Dojo side:

https://github.com/dojoengine/dojo/blob/60c1575927db63e98ababda56c5ffa9f6337fb56/crates/katana/core/src/sequencer.rs

so that we need to replace it in the codebase to avoid relying on something deprecated.

Related #1389 (comment)

@tcoratger tcoratger added the enhancement Enhancement of the code, not introducing new features. label Sep 23, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Sep 23, 2024
@tcoratger tcoratger added the good first issue Good first issue for people wanting to contribute to this project. label Sep 23, 2024
@varun-doshi
Copy link

I can take this up
Any pointers would be helpful as well

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @varun-doshi!
Thanks for showing interest.
We've created an application for you to contribute to Kakarot zkEVM.
Go check it out on OnlyDust!

@tcoratger
Copy link
Contributor Author

@varun-doshi I think that you should wait for dojoengine/dojo#2467 because for now we still need to use this struct as long as it is used to initialize our testing sequencer using this:

https://github.com/dojoengine/dojo/blob/60c1575927db63e98ababda56c5ffa9f6337fb56/crates/dojo-test-utils/src/sequencer.rs#L38

@varun-doshi
Copy link

Understood...I'll wait for it go through and then get started here
Are we expecting Dojo to introduce SequencerConfig in some other way? Or would we be needing to recreate the functionality of SequencerConfig by ourselves in this codebase?

@greged93
Copy link
Contributor

hey @varun-doshi, just letting you know that dojoengine/dojo#2467 was merged.

@varun-doshi
Copy link

Thanks for the heads up @greged93
Just to confirm, I need to update SequencerConfig similar to how its done here dojoengine/dojo#2508 right?

Any specific files I need to correct or should I go through the entire codebase?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features. good first issue Good first issue for people wanting to contribute to this project.
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants