-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kola/test/docker: enable docker.selinux
for all arch
#225
Conversation
1e667dc
to
e327b59
Compare
kola/tests/docker/docker.go
Outdated
ClusterSize: 1, | ||
Name: "docker.selinux", | ||
Distros: []string{"cl"}, | ||
Channels: []string{"alpha", "beta"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While at it we should switch this to using MinVersion
or we will forget this when the next channel transition happens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MinVersion: semver.Version{Major: 2942},
should mean everything newer, including the current beta?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not MinVersion: semver.Version{Major: 2984},
? SELinux changes will be available only in the next alpha
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, I just thought about the existing beta
value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an edge case actually:
- SELinux
amd64
is available onalpha
/beta
- SELinux
arm64
is only onmain
atm
so:
MinVersion: semver.Version{Major: 2942},
: will make the test fail onarm64
for both beta / alphaMinVersion: semver.Version{Major: 2984},
: will make the test disappears foramd64
for both beta / alpha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, MinVersion: semver.Version{Major: 2984},
is the right one :D (Edit: no, see below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to skip the tests than have them fail when doing a bugfix release (Edit: no, see below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, wait, didn't get it fully when reading the first time… we have no way to specify the version per architecture, complicated. I think it's ok to let it fail for arm64 on Alpha bugfix releases then and use 2942
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok done with 2942
:)
SELinux is now supported on ARM64 Signed-off-by: Mathieu Tortuyaux <[email protected]>
Signed-off-by: Mathieu Tortuyaux <[email protected]>
73043e6
to
617e4b8
Compare
SELinux is now supported on ARM64
Signed-off-by: Mathieu Tortuyaux [email protected]
Testing done