kola/tests/etcd: bind :2379 on all interfaces #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with `etcdctl/v3` default endpoints is: 127.0.0.1:2379 while with `etcdct/v2` it's http://127.0.0.1:2379,http://127.0.0.1:4001. `etcdct/v3` was failing to reach `127.0.0.1:2379` because it's bound to the private IPv4 (so `10.0.0.x`) Signed-off-by: Mathieu Tortuyaux <[email protected]>
sayanchowdhury
approved these changes
Aug 25, 2021
jepio
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with
etcdctl/v3default endpoints is: 127.0.0.1:2379 while withetcdct/v2it's http://127.0.0.1:2379,http://127.0.0.1:4001.etcdct/v3was failing to reach127.0.0.1:2379because it's boundto the private IPv4 (so
10.0.0.x) (see also other tests: https://github.com/kinvolk/mantle/blob/flatcar-master/kola/tests/etcd/discovery.go#L35)Signed-off-by: Mathieu Tortuyaux [email protected]
How to use
Testing done
⬆️