kola/docker: make selinux optional #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
reviewed
Jun 15, 2021
invidian
reviewed
Jun 15, 2021
|
@invidian thanks for your review ! Comments have been addressed :) |
sayanchowdhury
approved these changes
Jun 15, 2021
`selinux` support is going to be disabled on the next shipped Docker. To keep compatibility with current releases, selinux is made optional: we just assert that at least `seccomp`, `selinux` or both are enabled. this commit will be reverted once SELinux will be back on Flatcar Signed-off-by: Mathieu Tortuyaux <[email protected]>
tormath1
force-pushed
the
tormath1/disable-selinux-docker
branch
from
78fc03a to
9101e70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selinuxsupport is going to be disabled on the next shipped Docker.To keep compatibility with current releases, selinux is made optional:
we just assert that at least
seccomporselinuxor both areenabled.
this commit will be reverted once SELinux will be back on Flatcar
Signed-off-by: Mathieu Tortuyaux [email protected]