Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes and kubeadm tests: make it work on azure #176

Merged
merged 3 commits into from
May 31, 2021

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented May 28, 2021

In this PR, we try to get kubeadm tests working on Azure.

  • issue when we fetch the IP based on /run/metadata/flatcar

I investigated on other potential issues but it seems OK now. I had a doubt with some hardcoded time to live for the created instances but nothing in the code.

Testing done

./bin/kola run --board=amd64-usr --channel=stable --platform=azure ... kubeadm.base

(ran twice in a row)

closes flatcar/Flatcar#399

@tormath1 tormath1 self-assigned this May 28, 2021
@tormath1 tormath1 changed the title [wip] kola/test/kubeadm: make it works on azure kola/test/kubeadm: make it works on azure May 31, 2021
@tormath1 tormath1 requested a review from a team May 31, 2021 08:59
@tormath1 tormath1 marked this pull request as ready for review May 31, 2021 08:59
@pothos
Copy link
Member

pothos commented May 31, 2021

Thanks, I think this could also work for the kubernetes… test

@tormath1
Copy link
Contributor Author

@pothos it did the trick for kubernetes test (at least for v1.18.0)

@tormath1 tormath1 changed the title kola/test/kubeadm: make it works on azure kubernetes and kubeadm tests: make it work on azure May 31, 2021
Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, double approve

@pothos
Copy link
Member

pothos commented May 31, 2021

I would let it run on Jenkins and retry a few times to know whether the other versions are really broken (edit: and then we can exclude them).

Mathieu Tortuyaux added 2 commits May 31, 2021 12:09
On Azure, `coreos-metadata.service` populates `/run/metadata/flatcar`
with `COREOS_AZURE_IPV4_DYNAMIC=1.2.3.4`.
Since we grep the IP with `grep -E (PRIVATE|PUBLIC)` we were not able
to get a valid IPv4 which prevent nodes to correctly join the cluster
@tormath1 tormath1 force-pushed the tormath1/fix-azure-399 branch from 433f7c1 to b3137b5 Compare May 31, 2021 10:10
@tormath1 tormath1 merged commit 5a60b1d into flatcar-master May 31, 2021
@tormath1 tormath1 deleted the tormath1/fix-azure-399 branch May 31, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test/azure: kubeadm does not pass
2 participants