Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rkt and kubelet-wrapper from kubernetes tests #169

Merged
merged 9 commits into from
Apr 22, 2021

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Apr 20, 2021

in this PR, we remove the usage of rkt runtime and the kubelet-wrapper in order to prepare the removal of this components from the OS.

Testing done

It could run on QEMU but I have some memory issues. Tests have been done on GCP using alpha-2823.0.0:

./bin/kola run --basename=${BASENAME} \
    --gce-image=${IMAGE_NAME} \
    --gce-json-key=${GCE_JSON_KEY} \
    --parallel=4 --platform=gce \
    -d -k --remove=false \
    ${TEST_NAME}
2021-04-22T12:30:43Z cli: Started logging at level DEBUG
=== RUN   google.kubernetes.basic.docker.v1.18.0
2021-04-22T12:30:43Z kola/tests/kubernetes: Creating single-node etcd
2021-04-22T12:30:43Z platform/api/gcloud: Creating instance "tormath1-tests-rkt-68160e03b7993c51b9a5"
2021-04-22T12:31:05Z platform/api/gcloud: Created instance "tormath1-tests-rkt-68160e03b7993c51b9a5"
2021-04-22T12:31:56Z kola/tests/etcd: cluster healthy
2021-04-22T12:31:56Z kola/tests/kubernetes: Creating master node
2021-04-22T12:31:56Z platform/api/gcloud: Creating instance "tormath1-tests-rkt-b05d2e43908d6d471a3c"
2021-04-22T12:32:19Z platform/api/gcloud: Created instance "tormath1-tests-rkt-b05d2e43908d6d471a3c"
2021-04-22T12:32:54Z kola/tests/kubernetes: Generating TLS assets on the master
2021-04-22T12:33:24Z kola/tests/kubernetes: Creating worker nodes
2021-04-22T12:33:24Z platform/api/gcloud: Creating instance "tormath1-tests-rkt-c1a62bcae178faafba56"
2021-04-22T12:33:37Z platform/api/gcloud: Created instance "tormath1-tests-rkt-c1a62bcae178faafba56"
2021-04-22T12:34:17Z kola/tests/kubernetes: Generating TLS assets on the workers
2021-04-22T12:34:45Z kola/tests/kubernetes: Configuring nodes by running the install scripts
2021-04-22T12:36:00Z kola/tests/kubernetes: Configuring kubectl on the master
2021-04-22T12:36:10Z kola/tests/kubernetes: Waiting for all nodes to appear on kubectl
--- PASS: google.kubernetes.basic.docker.v1.18.0 (400.16s)

@tormath1 tormath1 self-assigned this Apr 20, 2021
@tormath1 tormath1 force-pushed the tormath1/remove-rkt-kubelet-wrapper branch 3 times, most recently from 3444b72 to ded42ee Compare April 22, 2021 09:34
Mathieu Tortuyaux added 7 commits April 22, 2021 14:20
kubelet-wrapper is deprecated, we use the official kubelet
kubelet-wrapper is deprecated, we use the official kubelet
basically this pod does nothing except checking that we can mount
a secret.
it has been merged into the nginx pod spec
it appears to be a bit overkill for testing purposes, also it creates
error like:
Error: failed to start container "healthz": Error response from daemon:
OCI runtime create failed: container_linux.go:367: starting container process
caused: process_linux.go:495: container init caused: process_linux.go:458:
setting cgroup config for procHooks process caused: failed to write "20971520":
write /sys/fs/cgroup/memory/kubepods/burstable/pod60a8ff48-\
e6bf-450d-b88d-db171f14147c/healthz/memory.limit_in_bytes: device or
resource busy: unknown
@tormath1 tormath1 force-pushed the tormath1/remove-rkt-kubelet-wrapper branch from ded42ee to a0112bf Compare April 22, 2021 12:40
@tormath1 tormath1 changed the title [wip]: remove rkt and kubelet-wrapper remove rkt and kubelet-wrapper Apr 22, 2021
@tormath1 tormath1 changed the title remove rkt and kubelet-wrapper remove rkt and kubelet-wrapper from kubernetes tests Apr 22, 2021
@tormath1 tormath1 marked this pull request as ready for review April 22, 2021 12:46
@tormath1 tormath1 requested a review from a team April 22, 2021 12:47
Mathieu Tortuyaux added 2 commits April 22, 2021 16:42
memory was a bit too low and could lead to some OOM errors from
time to time
@tormath1 tormath1 merged commit 5458169 into flatcar-master Apr 22, 2021
@tormath1 tormath1 deleted the tormath1/remove-rkt-kubelet-wrapper branch April 22, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants