Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform: allow CLC templating for dynamic IP address insertion #168

Merged
merged 4 commits into from
Apr 19, 2021

Conversation

pothos
Copy link
Member

@pothos pothos commented Apr 19, 2021

  • platform: allow CLC templating for dynamic IP address insertion
    The tests that require coreos-metadata and CLC templating could not
    run because for QEMU only a static replacement was done before the
    CLC configuration was rendered.
    Add support for the template variables by treating QEMU as a custom
    platform for the transpiler, making use of a coreos-metadata service
    that has the IP addresses hardcoded.

  • platform/machine/*/cluster.go: update custom coreos-metadata service

    The coreos-metadata service in the Flatcar OEMs normally writes to
    a "flatcar" file and symlinks it.
    Do the same for the custom ESX and QEMU coreos-metadata services.

  • platform/local/dnsmasq: hardcode DNS server for QEMU tests

    The system may have 127.0.0.53 as DNS server which is the
    systemd-resolved stub. This is no reachable from the dnsmasq's
    network namespace which has its own loopback interface.
    Hardcode the DNS servers to Cloudflare's and Google's to ensure
    DNS is working regardless of the host /etc/resolv.conf file.

  • kola/tests/*: enable more tests for QEMU

How to use/testing done

Run QEMU tests for

cl.locksmith.cluster cl.etcd-member.discovery cl.etcd-member.v2-backup-restore cl.etcd-member.etcdctlv3 cl.flannel.vxlan cl.flannel.udp coreos.ignition.security.tls

@pothos pothos requested a review from tormath1 April 19, 2021 10:47
The tests that require coreos-metadata and CLC templating could not
run because for QEMU only a static replacement was done before the
CLC configuration was rendered.
Add support for the template variables by treating QEMU as a custom
platform for the transpiler, making use of a coreos-metadata service
that has the IP addresses hardcoded.
@pothos pothos force-pushed the kai/qemu-all-tests branch from 6ddb597 to d139a66 Compare April 19, 2021 10:57
pothos added 2 commits April 19, 2021 14:23
The coreos-metadata service in the Flatcar OEMs normally writes to
a "flatcar" file and symlinks it.
Do the same for the custom ESX and QEMU coreos-metadata services.
The system may have 127.0.0.53 as DNS server which is the
systemd-resolved stub. This is no reachable from the dnsmasq's
network namespace which has its own loopback interface.
Hardcode the DNS servers to Cloudflare's and Google's to ensure
DNS is working regardless of the host /etc/resolv.conf file.
@pothos pothos force-pushed the kai/qemu-all-tests branch 3 times, most recently from 7e204eb to 1f80e88 Compare April 19, 2021 13:34
@pothos pothos force-pushed the kai/qemu-all-tests branch from 1f80e88 to a6ae6ff Compare April 19, 2021 13:37
@pothos pothos marked this pull request as ready for review April 19, 2021 13:38
@pothos pothos requested a review from a team April 19, 2021 13:46
Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks :)

@pothos pothos merged commit 3e63cb5 into flatcar-master Apr 19, 2021
@pothos pothos deleted the kai/qemu-all-tests branch April 19, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants