kola: Add a filter to run tests based on offering #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
approved these changes
Jan 5, 2021
|
I've updated tests with the Offering param so that it is easier and cleaner in jenkins to just pass the parameter |
kola/tests/coretest/core.go
Outdated
| @@ -72,7 +72,8 @@ func init() { | |||
| "Useradd": TestUseradd, | |||
| "MachineID": TestMachineID, | |||
| }, | |||
| Distros: []string{"cl"}, | |||
| Distros: []string{"cl"}, | |||
| Offerings: []string{"basic", "pro"}, | |||
There was a problem hiding this comment.
I'm a bit confused here, do we really need to specify this field for each and every test? We don't do this for Architectures or Channels... Why do we need to do it for Offerings?
There was a problem hiding this comment.
I've updated Offerings similar to how Architectures and Channels are. I was thinking for a future case, where we have more offers, and miscalculated. Sorry for the confusion.
sayanchowdhury
force-pushed
the
sayan/add-kola-filter-offering-based
branch
2 times, most recently
from
d4a6f97 to
8d0bc58
Compare
With the introduction of the Pro offering, it is not possible to test Pro specific features or test just for Pro without them runing on the basic offering as well. This changes introduces a new flag that helps building a clear distinction between Pro and the nornal offering. Signed-off-by: Sayan Chowdhury <[email protected]>
Signed-off-by: Sayan Chowdhury <[email protected]>
sayanchowdhury
force-pushed
the
sayan/add-kola-filter-offering-based
branch
from
8d0bc58 to
a87b7cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kola: Add a filter to run tests based on offering
With the introduction of the Pro offering, it is not possible to
test Pro specific features or test just for Pro without them runing
on the basic offering as well. This changes introduces a new flag
that helps building a clear distinction between Pro and the nornal
offering.
The
excludeOfferingmaybe does not make sense now with two offeringbut kept it for future feasibility.
Signed-off-by: Sayan Chowdhury [email protected]
How to use
Testing done
Not done yet.