Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixing maximum call stack size exceeded error #639

Merged
merged 2 commits into from
Jan 10, 2024
Merged

fix: fixing maximum call stack size exceeded error #639

merged 2 commits into from
Jan 10, 2024

Conversation

tuanphamcybozu
Copy link
Contributor

Why

  • Fix the maximum call stack size exceeded error

What

  • flattern the function using iteration instead of recursion

How to test

  • TBD

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@tuanphamcybozu tuanphamcybozu requested review from a team and hung-cybo and removed request for a team January 3, 2024 07:33
hung-cybo
hung-cybo approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@hung-cybo hung-cybo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hung-cybo hung-cybo merged commit e9e20d4 into main Jan 10, 2024
10 checks passed
@hung-cybo hung-cybo deleted the fix/fixing-maximum-call-stack branch January 10, 2024 07:26
This was referenced Jan 10, 2024
Merged
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Jan 24, 2024
Merged
This was referenced Jan 31, 2024
Merged
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Feb 21, 2024
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Apr 3, 2024
Merged
This was referenced Jun 12, 2024
Merged
Closed
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Oct 1, 2024
Closed
This was referenced Oct 23, 2024
Merged
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Nov 6, 2024
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Dec 5, 2024
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Jan 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hung-cybo hung-cybo hung-cybo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuanphamcybozu @hung-cybo