Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: making false the default value of the delete command prompt #411

Merged
merged 2 commits into from
Jul 27, 2023
Merged

fix: making false the default value of the delete command prompt #411

merged 2 commits into from
Jul 27, 2023

Conversation

tuanphamcybozu
Copy link
Contributor

@tuanphamcybozu tuanphamcybozu commented Jul 26, 2023 •
edited
Loading

Why

  • Making false the default value of the delete command prompt

What

  • Change default value from true to false

How to test

  • Run delete command and check the default answer

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@tuanphamcybozu tuanphamcybozu marked this pull request as ready for review July 26, 2023 09:58
@tuanphamcybozu tuanphamcybozu requested review from a team and tasshi-me and removed request for a team July 26, 2023 09:58
@tuanphamcybozu tuanphamcybozu changed the title fix: making false is the default value of prompt of delete command fix: making false the default value of the delete command prompt Jul 27, 2023
hung-cybo
hung-cybo approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@hung-cybo hung-cybo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hung-cybo hung-cybo merged commit 2641ec3 into main Jul 27, 2023
@hung-cybo hung-cybo deleted the fix/change-default-prompt-value branch July 27, 2023 09:03
This was referenced Jul 27, 2023
Merged
Merged
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
Closed
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
Closed
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Sep 6, 2023
Closed
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Sep 13, 2023
Closed
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Sep 27, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Oct 4, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Oct 16, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Oct 25, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Nov 1, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Nov 15, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Dec 6, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Dec 27, 2023
Merged
This was referenced Jan 17, 2024
Merged
Merged
This was referenced Jan 31, 2024
Merged
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Feb 21, 2024
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Apr 3, 2024
Merged
This was referenced Jun 12, 2024
Merged
Closed
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Oct 1, 2024
Closed
This was referenced Oct 23, 2024
Merged
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Nov 6, 2024
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hung-cybo hung-cybo hung-cybo approved these changes

@tasshi-me tasshi-me Awaiting requested review from tasshi-me

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuanphamcybozu @hung-cybo