feat: specifying socket timeout #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hung-cybo
requested review from
a team and
tasshi-me
and removed request for
a team
tasshi-me
reviewed
Jul 25, 2023
tasshi-me
reviewed
Jul 25, 2023
src/utils/error.ts
Outdated
| @@ -49,6 +54,22 @@ export abstract class CliKintoneError extends Error { | |||
| } | |||
| } | |||
|
|
|||
| private _networkError(error: unknown): error is NetworkError { | |||
There was a problem hiding this comment.
Sorry, I have one more proposal.
The type guard function is better to be named as isXXX().
Suggested change
| private _networkError(error: unknown): error is NetworkError { | |
| private _isNetworkError(error: unknown): error is NetworkError { |
This was referenced Jan 17, 2024
This was referenced Jun 12, 2024
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When the user cannot execute cli-kintone caused of the user's network error, cli-kintone should finish the process and show the error without waiting time.
What
How to test
Checklist
pnpm lintandpnpm teston the root directory.