Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve memory usage of record export #311

Merged
merged 22 commits into from
May 10, 2023
Merged

feat: improve memory usage of record export #311

merged 22 commits into from
May 10, 2023

Conversation

tasshi-me
Copy link
Member

@tasshi-me tasshi-me commented Apr 17, 2023 •
edited
Loading

Why

#102

What

  1. fetch records by chunks and output them iteratively.

The basic design is the same as #218 .

How to test

yarn build
yarn test

node ./cli.js record export --app $APP_ID

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed yarn lint and yarn test on the root directory.

@tasshi-me tasshi-me marked this pull request as ready for review April 26, 2023 02:09
@tasshi-me tasshi-me requested review from a team and hung-cybo and removed request for a team April 26, 2023 02:09
ueokande
ueokande suggested changes Apr 26, 2023
View reviewed changes
src/record/import/usecases/__tests__/add/error.test.ts Outdated Show resolved Hide resolved
src/utils/error.ts Show resolved Hide resolved
src/record/export/index.ts Outdated Show resolved Hide resolved
src/record/export/repositories/localRecordRepositoryFromStream.ts Outdated Show resolved Hide resolved
src/record/export/repositories/stringifiers/csvStringifier/index.ts Outdated Show resolved Hide resolved
hung-cybo
hung-cybo reviewed Apr 26, 2023
View reviewed changes
src/utils/error.ts Outdated Show resolved Hide resolved
@tasshi-me tasshi-me force-pushed the feat/improve-memory-usage-of-export branch from ed424cb to 1766365 Compare April 27, 2023 10:05
@tasshi-me tasshi-me force-pushed the feat/improve-memory-usage-of-export branch from 23e2dac to 0a03e11 Compare April 27, 2023 18:39
tasshi-me
tasshi-me commented Apr 27, 2023
View reviewed changes
Copy link
Member Author

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ueokande @hung-cybo
I updated the PR reflecting your reviews!

  • fix bug of CsvStrinfigier
  • update CliKintoneError and remove redundant implementation of toString()
  • make some fields of Repository private
  • apply no-unused-imports and remove unused imports

@tasshi-me tasshi-me requested review from hung-cybo and ueokande April 27, 2023 18:58
hung-cybo
hung-cybo reviewed Apr 28, 2023
View reviewed changes
Copy link
Contributor

@hung-cybo hung-cybo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some small comments.

src/record/export/repositories/stringifiers/index.ts Outdated Show resolved Hide resolved
src/record/export/repositories/error.ts Outdated Show resolved Hide resolved
src/record/export/usecases/get/__tests__/fixtures/can_download_files.ts Outdated Show resolved Hide resolved
src/record/export/usecases/get/__tests__/fixtures/can_download_files_in_subtable.ts Outdated Show resolved Hide resolved
src/record/export/usecases/get/__tests__/fixtures/can_get_records.ts Outdated Show resolved Hide resolved
src/record/export/usecases/get/__tests__/getAllRecords.test.ts Outdated Show resolved Hide resolved
@tasshi-me tasshi-me requested a review from ueokande May 9, 2023 01:53
@tasshi-me tasshi-me merged commit 1c545c7 into main May 10, 2023
@tasshi-me tasshi-me deleted the feat/improve-memory-usage-of-export branch May 10, 2023 01:46
@github-actions github-actions bot mentioned this pull request May 10, 2023
Merged
@tasshi-me
Copy link
Member Author

tasshi-me commented May 10, 2023 •
edited
Loading

It works well.
memory-usage-during-export-en
comparison-of-peak-memory-usage-export-en

@github-actions github-actions bot mentioned this pull request Aug 2, 2023
Merged
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
Closed
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
Closed
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Sep 6, 2023
Closed
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Sep 13, 2023
Closed
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Sep 27, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Oct 4, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Oct 16, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Oct 25, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Nov 1, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Nov 15, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Dec 6, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Dec 27, 2023
Merged
This was referenced Jan 17, 2024
Merged
Merged
This was referenced Jan 31, 2024
Merged
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Feb 21, 2024
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Apr 3, 2024
Merged
This was referenced Jun 12, 2024
Merged
Closed
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Oct 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueokande ueokande ueokande approved these changes

@hung-cybo hung-cybo Awaiting requested review from hung-cybo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tasshi-me @ueokande @hung-cybo