Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade confused by multiple instances of the same package, writes invalid config #536

Closed
awused opened this issue Nov 12, 2021 · 3 comments

Comments

@awused
Copy link

awused commented Nov 12, 2021

I have a project that depends on both image git and image v23 for compatibility with other crates.

[dependencies]
image_23 = { package = "image", version = "0.23.14" }
image = { git = "https://github.com/image-rs/image" }

cargo upgrade --dry-run showed no changes related to image, but running cargo upgrade changed the config to:

[dependencies]
image_23 = { package = "image", version = "0.23.14" }
image = { version = "0.23.14", package = "image" }

After the upgrade the config was invalid since it was depending on image v23 twice under different names.

@ordian
Copy link
Collaborator

ordian commented Nov 12, 2021

Duplicate of #432.

@awused
Copy link
Author

awused commented Nov 12, 2021

I'm not sure this is a simple dupe, or if it is it's a different symptom, because this one is downgrading a manually set git dependency to an earlier published version.

@ordian
Copy link
Collaborator

ordian commented Jul 14, 2022

This is resolved now at least after #725

@ordian ordian closed this as completed Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants