Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(developer): New Project creates old format model projects and has missing welcome.htm link #13135

Closed
1 of 8 tasks
DavidLRowe opened this issue Feb 6, 2025 · 1 comment · Fixed by #13161
Closed
1 of 8 tasks
Assignees
Milestone

Comments

@DavidLRowe
Copy link
Contributor

Is your feature request related to a problem? Please describe.

There are several things where the New Project processing could be improved.

(1) New Project for lexical models doesn't create v17 format .kpj file and still creates .model_info file. For example:
Project, New Project, Wordlist Lexical Model, OK
Author: abc
Model: def
Description: Test
BCP 47: wwa
OK, to create abc.wwa.def\abc.wwa.def.model.kpj
This creates a .kpj file in the old (pre-v17) format, but offers an Upgrade project button.
After the upgrade, the .kpj file is in v17 format, but there's still a .model_info file that needs deletion. (In contrast, when creating a new keyboard project, the .kpj file is already in v17 format and no .keyboard_info file is created.)

(2) New Project for keyboard doesn't include link to welcome.htm in .kps file. (That is, on Details tab, "Welcome file:" field has "(none"), even though a welcome.htm file has been created in the source folder.

Describe the solution you'd like

(1) lexical model projects should use v17 format .kpj files
(2) keyboard projects should include a welcome.htm link in the .kps file. (May apply to lexical model projects as well.)

Describe alternatives you've considered

Manually edit (or ask keyboard authors to edit) files to make these changes.

Related issues

No response

Keyman apps

  • Keyman for Android
  • Keyman for iPhone and iPad
  • Keyman for Linux
  • Keyman for macOS
  • Keyman for Windows
  • Keyman Developer
  • KeymanWeb
  • Other - give details at bottom of form

Keyman version

17.0.334

Operating system

No response

Device

No response

Target application

No response

Browser

No response

Keyboard name

No response

Keyboard version

No response

Language name

No response

Additional context

No response

@DavidLRowe DavidLRowe added the feat label Feb 6, 2025
@mcdurdin mcdurdin changed the title feat: improve New Project experience feat(developer): improve New Project experience Feb 6, 2025
@mcdurdin
Copy link
Member

mcdurdin commented Feb 6, 2025

Thanks for this report.

I'm going to reclassify these as bugs -- and fix them during beta -- because both are things that are wrong, and both are simple fixes.

@mcdurdin mcdurdin changed the title feat(developer): improve New Project experience bug(developer): New Project creates old format model projects and has missing welcome.htm link Feb 6, 2025
@keymanapp-test-bot keymanapp-test-bot bot added bug and removed feat labels Feb 6, 2025
@mcdurdin mcdurdin self-assigned this Feb 6, 2025
@mcdurdin mcdurdin added this to the B18S1 milestone Feb 6, 2025
@mcdurdin mcdurdin moved this to Todo in Keyman Feb 6, 2025
@mcdurdin mcdurdin moved this from Todo to In Progress in Keyman Feb 7, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Keyman Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
2 participants