Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(developer): und-Latn language tag is undefined in Intl.Locale and leads to TypeError: Cannot read properties of undefined (reading 'toLowerCase') in @keymanapp/langtags #13116

Open
sentry-io bot opened this issue Feb 3, 2025 · 0 comments · May be fixed by #13117
Open

bug(developer): und-Latn language tag is undefined in Intl.Locale and leads to TypeError: Cannot read properties of undefined (reading 'toLowerCase') in @keymanapp/langtags #13116

sentry-io bot opened this issue Feb 3, 2025 · 0 comments · May be fixed by #13117
Assignees
@mcdurdin
Labels
bug developer/
Milestone
B18S1

Comments

@sentry-io
Copy link

sentry-io bot commented Feb 3, 2025

Sentry Issue: KEYMAN-DEVELOPER-2GJ

TypeError: Cannot read properties of undefined (reading 'toLowerCase')
  File "D:\Projects\keyman\app\common\web\langtags\src\main.ts", line 117, in getLangtagByTag
    return langtagsByTag.get(tag.toLowerCase());
  File "D:\Projects\keyman\app\developer\src\kmc-keyboard-info\src\keyboard-info-compiler.ts", line 549, in KeyboardInfoCompiler.fillLanguages
    language.regionName = mapName(locale.region, regionNames);
  File "D:\Projects\keyman\app\developer\src\kmc-keyboard-info\src\keyboard-info-compiler.ts", line 236, in KeyboardInfoCompiler.run
    if(!await this.fillLanguages(sources.kpsFilename, keyboard_info, kmpJsonData)) {
  File "D:\Projects\keyman\app\developer\src\kmc\src\commands\buildClasses\BuildActivity.ts", line 19, in BuildKeyboardInfo.runCompiler
    const result = await compiler.run(infile, outfile);
  File "D:\Projects\keyman\app\developer\src\kmc\src\commands\buildClasses\BuildKeyboardInfo.ts", line 56, in BuildKeyboardInfo.build
    return await super.runCompiler(compiler, infile, outputFilename, callbacks, {...options, sources});
...
(5 additional frame(s) were not displayed)
@mcdurdin mcdurdin mentioned this issue Feb 3, 2025
Merged
@mcdurdin mcdurdin added this to the B18S1 milestone Feb 3, 2025
@mcdurdin mcdurdin moved this to Todo in Keyman Feb 3, 2025
@mcdurdin mcdurdin changed the title bug(developer): TypeError: Cannot read properties of undefined (reading 'toLowerCase') bug(developer): und-Latn language tag causes TypeError: Cannot read properties of undefined (reading 'toLowerCase') in @keymanapp/langtags Feb 3, 2025
@mcdurdin mcdurdin changed the title bug(developer): und-Latn language tag causes TypeError: Cannot read properties of undefined (reading 'toLowerCase') in @keymanapp/langtags bug(developer): und-Latn language tag is undefined in Intl.Locale so causes TypeError: Cannot read properties of undefined (reading 'toLowerCase') in @keymanapp/langtags Feb 3, 2025
@mcdurdin mcdurdin changed the title bug(developer): und-Latn language tag is undefined in Intl.Locale so causes TypeError: Cannot read properties of undefined (reading 'toLowerCase') in @keymanapp/langtags bug(developer): und-Latn language tag is undefined in Intl.Locale and leads to TypeError: Cannot read properties of undefined (reading 'toLowerCase') in @keymanapp/langtags Feb 3, 2025
mcdurdin added a commit that referenced this issue Feb 3, 2025
@mcdurdin
fix(common): handle undefined input in @keymanapp/langtags lookups
5fea5b3 
Matches prior behaviour when langtags was part of kmc-keyboard-info.

Fixes: #13116
@mcdurdin mcdurdin linked a pull request Feb 3, 2025 that will close this issue
Open
@mcdurdin mcdurdin moved this from Todo to In Progress in Keyman Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
bug developer/
Projects
Keyman
Status: In Progress
Milestone
B18S1
Development

Successfully merging a pull request may close this issue.

fix(common): handle undefined input in @keymanapp/langtags lookups keymanapp/keyman
1 participant
@mcdurdin