-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(windows): Investigate if VKContextReset is needed in for core on kmx processor #10227
Comments
I have tested some of the keys by running keyman. However, it is hard to test when the context would be reset anyway (focus changing). The |
I have run the test host program and tested the keys available to me on my keyboard. There are a number of keys that reset the context that had a value of '0' in the Note: This table is replicated in the core
|
I ended up adding logging to test the LDML processor. For non-compliant apps (non-context aware), it is never resetting context for a key press from the list above (well for any key). I realise now this has occurred because the action struct that the LDML processor is giving to the core does not have the option to invalidate the context. Both LDML and KMX never inserted the \ - * keys from the number pad into the context, I am pretty sure they both are hitting the emit keystroke code. However, KMX resets context where as LDML does not. We have 2 issues.
|
In reviewing #10090 it become apparent that the call to reset the context in the windows engine base upon the table VKContextReset was no longer used. This ticket is to investigate if it is still needed if so integrated into the core. Also remove the Array from the Windows engine.
Remove extern const int VKContextReset[256]; from the Windows Engine
Store palce const int VKContextReset[256]; in the Core if it is needed
The text was updated successfully, but these errors were encountered: