Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tagging is working again #213

Merged
merged 1 commit into from
Feb 11, 2025
Merged

fix: Tagging is working again #213

merged 1 commit into from
Feb 11, 2025

Conversation

micz
Copy link
Contributor

@micz micz commented Feb 11, 2025

Tagging is currently giving this error:

Uncaught (in promise) Error: Type error for parameter newProperties (Error processing tags.0: Expected string instead of undefined) for messages.update.
    applyTags moz-extension://e7252b71-5fcf-458f-af21-905f604adfad/background.js:117
    applyTags moz-extension://e7252b71-5fcf-458f-af21-905f604adfad/background.js:102
    spinWith moz-extension://e7252b71-5fcf-458f-af21-905f604adfad/background.js:31
    <anonymous> moz-extension://e7252b71-5fcf-458f-af21-905f604adfad/background.js:181
    load moz-extension://e7252b71-5fcf-458f-af21-905f604adfad/popup/popup.js:186
    dispatchSelect moz-extension://e7252b71-5fcf-458f-af21-905f604adfad/popup/baseItemList.js:378
    itemListClick moz-extension://e7252b71-5fcf-458f-af21-905f604adfad/popup/baseItemList.js:368
    connectedCallback moz-extension://e7252b71-5fcf-458f-af21-905f604adfad/popup/baseItemList.js:247
    <anonymous> moz-extension://e7252b71-5fcf-458f-af21-905f604adfad/popup/tagList.js:27
background.js:117:31

this PR fixes the issue.

@kewisch
Copy link
Owner

kewisch commented Feb 11, 2025

lgtm, thanks!

@kewisch kewisch merged commit 6afcbd1 into kewisch:main Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants