Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherited environment-specific build #214

Closed
kettanaito opened this issue Mar 18, 2018 · 1 comment
Closed

Inherited environment-specific build #214

kettanaito opened this issue Mar 18, 2018 · 1 comment
Assignees
@kettanaito
Labels
enhancement Enhances existing functionality. good first issue Good for newcomers. help wanted Extra attention is needed
Milestone
1.x

Comments

@kettanaito
Copy link
Owner

What

Need to inherit the environment with which the library is built and build it repsectively.

Why

When building a project in development mode, RAF should build in development mode as well, preserving some helpful warnings/messages. When project is built for production - the same should happen with RAF, stripping warnings, propTypes, etc. Basically, RAF should build as React library does.

How

  • See if current way of bundling is not enough
  • See how React or similar env-dependant package is built
  • Read about this way of building the library
@kettanaito kettanaito added the enhancement Enhances existing functionality. label Mar 18, 2018
@kettanaito kettanaito added this to the Release 2.0 milestone Mar 18, 2018
@kettanaito kettanaito modified the milestones: 2.0, 1.x.x Mar 23, 2018
@kettanaito kettanaito added help wanted Extra attention is needed good first issue Good for newcomers. labels Mar 28, 2018
@kettanaito kettanaito self-assigned this Mar 28, 2018
@kettanaito kettanaito mentioned this issue Mar 28, 2018
Merged
@kettanaito
Copy link
Owner Author

Merged and published under 1.1.0. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kettanaito kettanaito

Labels
enhancement Enhances existing functionality. good first issue Good for newcomers. help wanted Extra attention is needed
Projects
None yet
Milestone
1.x
Development

No branches or pull requests
1 participant
@kettanaito