Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up optional dependencies listed in setup.py #687

Closed
mattdangerw opened this issue Jan 23, 2023 · 3 comments
Closed

Clean up optional dependencies listed in setup.py #687

mattdangerw opened this issue Jan 23, 2023 · 3 comments
Assignees
Labels
type:Bug Something isn't working

Comments

@mattdangerw
Copy link
Member

We have some optional dependencies listed in our setup.py that have grown a little stale.

The setup.py files are no longer a complete list of dependencies for a development environment (that has moved to our requirements.txt), there are also a lot of dependencies here specific to our BERT pretraining example only.

We might want to pare this list down to just the optional dependencies for the install package itself--which is just setencepiece and rogue-score.

@mattdangerw mattdangerw added the type:Bug Something isn't working label Jan 23, 2023
@mattdangerw mattdangerw self-assigned this Jan 23, 2023
@ADITYADAS1999
Copy link
Contributor

We have some optional dependencies listed in our setup.py that have grown a little stale.

The setup.py files are no longer a complete list of dependencies for a development environment (that has moved to our requirements.txt), there are also a lot of dependencies here specific to our BERT pretraining example only.

We might want to pare this list down to just the optional dependencies for the install package itself--which is just setencepiece and rogue-score.

hey @mattdangerw this issue is open for contributors ?

@mattdangerw
Copy link
Member Author

This is already in flight in #697

I will be opening up some more issues early next week, in particular for replicating the changes in #653 for other encoder models. I could assign one of those to you if you are on the hunt for more issues!

@ADITYADAS1999
Copy link
Contributor

This is already in flight in #697

I will be opening up some more issues early next week, in particular for replicating the changes in #653 for other encoder models. I could assign one of those to you if you are on the hunt for more issues!

Thank you @mattdangerw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants