Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a BLEU metric #65

Closed
mattdangerw opened this issue Mar 25, 2022 · 5 comments · Fixed by #222
Closed

Add a BLEU metric #65

mattdangerw opened this issue Mar 25, 2022 · 5 comments · Fixed by #222
Assignees
@abheesht17
Labels
type:feature New feature or request

Comments

@mattdangerw
Copy link
Member

Splitting this issue out from #38.

We should add a BLEU metric as keras_nlp.metrics.Bleu.
@mattdangerw mattdangerw added the type:feature New feature or request label Mar 25, 2022
@abheesht17
Copy link
Collaborator

abheesht17 commented Mar 25, 2022 •
edited
Loading

Linking a comment here which explains the difficulty with BLEU:
#38 (comment)

For ROUGE Score, I used a TensorArray for ngrams, which has a write operation. Maybe, we can use the same here.

@arcAman07
Copy link

If this issue is open, I would want to work on implementing the BLEU metric.

@abheesht17
Copy link
Collaborator

Hello, @arcAman07! I'm currently working on this.

@arcAman07
Copy link

Cool, wasn't aware of it 👍

@abheesht17
Copy link
Collaborator

Rough Implementation: https://colab.research.google.com/drive/1uX5V98N1apnNHJTLQAecIz2H8yQfL5fK?usp=sharing

@abheesht17 abheesht17 mentioned this issue Jun 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abheesht17 abheesht17

Labels
type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add BLEU Score abheesht17/keras-nlp
3 participants
@mattdangerw @abheesht17 @arcAman07