Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port RoBERTa to follow Bert model changes #403

Closed
mattdangerw opened this issue Oct 21, 2022 · 1 comment · Fixed by #417
Closed

Port RoBERTa to follow Bert model changes #403

mattdangerw opened this issue Oct 21, 2022 · 1 comment · Fixed by #417
Assignees
@abheesht17
Labels
stat:contributions welcome Add this label to feature request issues so they are separated out from bug reporting issues type:feature New feature or request

Comments

@mattdangerw
Copy link
Member

We had a few larger changes to the bert API:
#387
#390

As well as some minor cleanups:
#397
#398
#399

We should mirror these where applicable to the RoBERTa model code. Since we do not yet host pretrained weight for this model, we can just raise a NotImplementedError in from_preset for now.
@mattdangerw mattdangerw added type:feature New feature or request stat:contributions welcome Add this label to feature request issues so they are separated out from bug reporting issues labels Oct 21, 2022
@jbischof
Copy link
Contributor

See #406 for example PR, thanks in advance!

@abheesht17 abheesht17 mentioned this issue Oct 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abheesht17 abheesht17

Labels
stat:contributions welcome Add this label to feature request issues so they are separated out from bug reporting issues type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change RoBERTa and XLM-RoBERTa's Format to Mirror BERT's abheesht17/keras-nlp
3 participants
@jbischof @mattdangerw @abheesht17