Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port DistilBert to follow Bert model changes #402

Closed
mattdangerw opened this issue Oct 21, 2022 · 0 comments · Fixed by #406
Closed

Port DistilBert to follow Bert model changes #402

mattdangerw opened this issue Oct 21, 2022 · 0 comments · Fixed by #406
Assignees
@mattdangerw
Labels
type:feature New feature or request

Comments

@mattdangerw
Copy link
Member

We had a few larger changes to the bert API:
#387
#390

As well as some minor cleanups:
#397
#398
#399

We should mirror these where applicable to the DistilBert model code. Since we do not yet host pretrained weight for this model, we can just raise a NotImplementedError in from_preset for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattdangerw mattdangerw

Labels
type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update distilbert to mirror recent bert changes mattdangerw/keras-hub
1 participant
@mattdangerw