Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add VideoSwin #1755

Open
divyashreepathihalli opened this issue Aug 8, 2024 · 4 comments
Open

add VideoSwin #1755

divyashreepathihalli opened this issue Aug 8, 2024 · 4 comments
Assignees
Labels
keras-hub Part of teh consolidation repository for KerasCV and KerasNLP stat:contributions welcome Add this label to feature request issues so they are separated out from bug reporting issues team-created Issues created by Keras Hub team as part of development roadmap.

Comments

@divyashreepathihalli
Copy link
Collaborator

divyashreepathihalli commented Aug 8, 2024

This task is part of the KerasHub project ( Consolidating all of KerasCV and KerasNLP models in to one place)
Models from KerasCV will be added to KerasNLP in KerasNLP infrstructure style. The development is now under the keras-hub branch in KerasNLP - https://github.com/keras-team/keras-nlp/tree/keras-hub

Steps to complete this Task

Add either @divyashreepathihalli, @mattdangerw or @SamanehSaadat for review of any PR.

@divyashreepathihalli divyashreepathihalli converted this from a draft issue Aug 8, 2024
@divyashreepathihalli divyashreepathihalli added stat:contributions welcome Add this label to feature request issues so they are separated out from bug reporting issues keras-hub Part of teh consolidation repository for KerasCV and KerasNLP labels Aug 8, 2024
@ushareng ushareng self-assigned this Aug 19, 2024
@kernel-loophole
Copy link

kernel-loophole commented Nov 5, 2024

@divyashreepathihalli I'm interested in contributing to this task for the KerasHub project by adding models from KerasCV to KerasNLP in the specified format. Before I get started, could you clarify a few things?

File Locations: Could you confirm if the full path for the source files is keras-cv/keras_cv/src/models/backbones/video_swin? Additionally, should all files within this folder be moved to a new folder under keras-nlp/keras_nlp/src/models?

Model Configuration: For models with multiple versions, do you have any preferred method or example in KerasNLP to manage these configurations within the model’s arguments?

Testing Requirements: Are there any specific test cases or benchmarks for video models that need to be prioritized during testing, or should I follow the general test routines provided in KerasNLP?

@kernel-loophole
Copy link

kernel-loophole commented Nov 7, 2024

@divyashreepathihalli is this model will be placed in this path https://github.com/keras-team/keras-hub/tree/keras-hub/keras_nlp/src/models and how can test if the model is working or not

@sachinprasadhs sachinprasadhs added the team-created Issues created by Keras Hub team as part of development roadmap. label Nov 8, 2024
@Swap98
Copy link

Swap98 commented Jan 22, 2025

@divyashreepathihalli I'm interesting in contributing to this task of adding models from KerasCV to KerasNLP

@divyashreepathihalli
Copy link
Collaborator Author

Hey @Swap98 looks like @kernel-loophole responded on the PR. He might be actively looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keras-hub Part of teh consolidation repository for KerasCV and KerasNLP stat:contributions welcome Add this label to feature request issues so they are separated out from bug reporting issues team-created Issues created by Keras Hub team as part of development roadmap.
Projects
Status: In Progress
Development

No branches or pull requests

5 participants