-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate ELECTRA Pretrained Model into Keras_NLP Ecosystem #1281
Comments
Electra would be a welcome addition! Thanks! As mentioned in the model contribution guide, first thing to do would be to write a backbone and a checkpoint conversion script from a known source that shows we can match outputs. Huggingface might be the easiest checkpoint source. The original electra repo would be totally fine as well, but looks like the implementation is in tf1, which would be a little painful to work with. |
Thanks for assigning the issue, I'll start working on it |
@mattdangerw I had one Colab floating around which would implement electra in KerasNLP, will share if I find . Would be helpful for @pranavvp16 |
@shivance thanks for the notebook but I think the notebook shares the pre-training approach of |
Yes that's definitely a good approach! Let's start with the backbone, not the pretraining approach. The pretraining approach would make for an excellent keras.io example (which was #794), but beginning with a backbone is the right first step on adding this model to our API. Will take a look at the issues on the PR shortly! |
I would like to add ELECTRA pretrained model in the keras_nlp ecosystem. I have went through the
CONTRIBUTINT_MODELS.md
and making an issue is the first task to add the model. I have pretty good understanding of transformers and have went through the ELECTRA architecture mentioned here. So if there is no problem regarding the integration I can start working on this !!The text was updated successfully, but these errors were encountered: