Skip to content

JitterResize updates #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martin-gorner opened this issue May 9, 2023 · 8 comments
Closed

JitterResize updates #1768

martin-gorner opened this issue May 9, 2023 · 8 comments

Comments

@martin-gorner
Copy link

Looking through the friction log: https://docs.google.com/document/d/1xoq2axs1QHWvRjKRQP-L8HSlputy3N3R9Q5Glp-lN4g/edit#bookmark=id.262un4qwr0if
The most important tasks for now are:

  • name change -> RandomZoomAndCrop
  • crop box params change: remove target_size, split crop size into crrop_width, crop_height
  • Deprecate and delete existing RandomlyZoomedCrop layer
  • To align params on the new "Zoom" naming, params change scale_factor => zoom_factor (this might be the inverse of scale_factor, please check)
    The other 5 points are less important, nice-to-have later.
@LukeWood
Copy link
Contributor

LukeWood commented May 9, 2023

There are cases where multiple input sizes are needed for preprocessing techniques: https://github.com/tensorflow/models/blob/526e80f0c03b876757f845b3e8cb5c61f7c96e2f/official/vision/dataloaders/segmentation_input.py#L75

There are others as well.

@martin-gorner
Copy link
Author

The goal is to be consistent with all other preprocessing layers which use explicit width and height parameters (or x and y) and not size=(...,...) tuples

keras_cv.layers.RandomCutout(height_factor, width_factor, ...)
keras_cv.layers.RandomShear(x_factor, y_factor, ...)
keras_cv.layers.Resizing(height, width, ...)
keras.layers.CenterCrop(height, width, ...)
keras.layers.RandomCrop(height, width, ...)
keras.layers.RandomTranslation(height_factor, width_factor, ...)
keras.layers.RandomZoom(height_factor, width_factor, ...)

@LukeWood
Copy link
Contributor

LukeWood commented May 9, 2023

I think for the height and width distortion factors separating them makes sense.

For CenterCrop+RandomCrop+Resizing I wish we had gone with a tuple - though was not around for those designs.

@james77777778
Copy link
Contributor

I'm willing to contribute but I can't access the google docs.
Is this contributions-welcome?

@jbischof
Copy link
Contributor

Thanks for the issue @martin-gorner! Ideally we could offer artifacts as a github gist to be accessible to the community.

@sachinprasadhs
Copy link
Collaborator

Thanks for reporting the issue! We have consolidated the development of KerasCV into the new KerasHub package, which supports image, text, and multi-modal models. Please read keras-team/keras-hub#1831. KerasHub will support all the core functionality of KerasCV.

KerasHub can be installed with !pip install -U keras-hub. Documentation and guides are available at keras.io/keras_hub.

With our focus shifted to KerasHub, we are not planning any further development or releases in KerasCV. If you encounter a KerasCV feature that is missing from KerasHub, or would like to propose an addition to the library, please file an issue with KerasHub.

Copy link

github-actions bot commented Mar 3, 2025

This issue is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale label Mar 3, 2025
Copy link

This issue was closed because it has been inactive for 28 days. Please reopen if you'd like to work on this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants