Fix the path uniqueness problem #3
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 50 46 -4
Branches 4 4
=====================================
- Hits 50 46 -4
Continue to review full report at Codecov.
|
kentcdodds
force-pushed
the
fix-uniqueness-problem
branch
2 times, most recently
from
36ab4cd to
98163fe
Compare
src/__tests__/macro.js
Outdated
|
|
||
| expect.addSnapshotSerializer({ | ||
| print(val) { | ||
| return val | ||
| .split(projectRoot) | ||
| .join('<PROJECT_ROOT>/') | ||
| .replace(/fixtures/g, 'my-files') | ||
| .replace(/fixtures/g, 'my_files') |
There was a problem hiding this comment.
I realized later why you did that. I changed it to simply files because I don't like snake_case 😉
Thanks!
Used other/snap-to-readme.js to update the README.md
kentcdodds
force-pushed
the
fix-uniqueness-problem
branch
from
98163fe to
73188d0
Compare
|
Thank you so much! |
|
Would you like to add yourself to the contributors table? |
|
Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the CONTRIBUTING.md file (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :) |
|
Oh, and the MAINTAINING.md file is useful too. |
|
Thanks, I'll add myself then :) |
|
Great! I'll look forward to your pull request 👍 |
This fixes #2.