Fix module resolution for preval.require #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbekrin
commented
Oct 5, 2017
| @@ -121,7 +119,7 @@ function prevalPlugin({types: t, template, transformFromAst}) { | |||
| } | |||
| return result.value | |||
| }) | |||
| const absolutePath = p.join(p.dirname(filename), source.node.value) | |||
| const absolutePath = p.resolve(p.dirname(filename), source.node.value) | |||
There was a problem hiding this comment.
This is actual change, rest of the stuff is formatted by prettier I believe
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 98 98
Branches 20 20
=====================================
Hits 98 98
Continue to review full report at Codecov.
|
|
Thanks! Could you add a test to verify that the bug you found has been fixed and make sure it doesn't come back? 👍 |
|
@kentcdodds will do 🙌 Meanwhile, can you suggest most suitable structure for that kind of test? Can't think of anything but creating nested directory in tests. |
|
You could do it in fixtures 👍 |
|
That was quick! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
path.join->path.resolveWhy:
preval.requirewon't resolve non-top level pathsHow: by updating code which resolves absolute path to module
This PR fixes an issue then using
preval.require('../../foo');for non-top level modules. This results in resolution from incorrect base parent directory and throwsModule not foundwith actually correct (from project root perspective) path, which is super confusing.