Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing BigInteger behavior to support all numeric types in math method signatures #82

Open
kellyethridge opened this issue Oct 16, 2020 · 0 comments
Labels
breaking binary compatibility issue enhancement

Comments

@kellyethridge
Copy link
Owner

Right now BigInteger and BigIntegerStatic only accept BigInteger type in the math method calls. Consider changing the signatures to Variant and converting to BigInteger in the method to allow support for other numeric types.

This currently results in a "Type Mismatch" error. It would be useful to allow such method calls.

Set Answer = BigInteger.Add(Int64.MaxValue, &h7FFFFFFF)

To achieve this now we need to use the CBigInt conversion method which can become unwieldy.

Set Answer = BigInteger.Add(CBigInt(Int64.MaxValue), CBigInt(&h7FFFFFFF))
@kellyethridge kellyethridge added breaking binary compatibility issue enhancement labels Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking binary compatibility issue enhancement
Projects
None yet
Development

No branches or pull requests

1 participant