Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update repo, tests, and workflow to support Node 22 #902

Closed
intcreator opened this issue Oct 29, 2024 · 3 comments · Fixed by #957
Closed

Update repo, tests, and workflow to support Node 22 #902

intcreator opened this issue Oct 29, 2024 · 3 comments · Fixed by #957
Assignees
@intcreator
Labels
released type:feature New feature or feature improvement & requests

Comments

@intcreator
Copy link
Collaborator

⭐ Suggestion

Node 16 is at end-of-life so we should adjust our workflow to test on versions 18, 20, and 22 instead of 16, 28, and 20. it's possible some of our base code and tests will need to be updated as well

💻 Use Cases

No response

❌ Related Problems

No response
@intcreator intcreator added the type:feature New feature or feature improvement & requests label Oct 29, 2024
@intcreator intcreator self-assigned this Oct 29, 2024
@intcreator
Copy link
Collaborator Author

note for future me: dropping support for Node 16 will be a breaking change, so we will need to release a new version. If there are any other breaking changes to make now would be a good time to make them

@intcreator intcreator mentioned this issue Nov 1, 2024
Merged
1 task
@intcreator
Copy link
Collaborator Author

new note, let's keep supporting Node 16 for the foreseeable future so we don't have to bump the major version so much

@intcreator intcreator mentioned this issue Feb 18, 2025
Merged
9 tasks
@ncb000gt
Copy link
Member

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

WillianAgostini pushed a commit to WillianAgostini/node-cron that referenced this issue Feb 19, 2025
@semantic-release-bot
Release v4.0.0 [skip ci]
1221026 
## [4.0.0](kelektiv/node-cron@v3.5.0...v4.0.0) (2025-02-19)

### ⚠ Breaking changes

* drop support for Node v16 and rename job.running to job.isActive (kelektiv#957)

### 📦 Code Refactoring

* drop support for Node v16 and rename job.running to job.isActive ([kelektiv#957](kelektiv#957)) ([605e94e](kelektiv@605e94e)), closes [kelektiv#902](kelektiv#902) [kelektiv#905](kelektiv#905)

### ♻️ Chores

* **action:** update actions/checkout action to v4.2.2 ([kelektiv#927](kelektiv#927)) ([ff1721e](kelektiv@ff1721e))
* **action:** update actions/setup-node action to v4.1.0 ([kelektiv#928](kelektiv#928)) ([3e27773](kelektiv@3e27773))
* **action:** update actions/upload-artifact action to v4.6.0 ([kelektiv#931](kelektiv#931)) ([8283000](kelektiv@8283000))
* **action:** update amannn/action-semantic-pull-request action to v5.5.3 ([kelektiv#929](kelektiv#929)) ([f1851d7](kelektiv@f1851d7))
* **action:** update github/codeql-action action to v3.28.1 ([kelektiv#922](kelektiv#922)) ([eefd476](kelektiv@eefd476))
* **deps:** lock file maintenance ([c3af5fc](kelektiv@c3af5fc))
* **deps:** lock file maintenance ([d689a1c](kelektiv@d689a1c))
* **renovate:** improve schedules & automerging to reduce noise ([kelektiv#942](kelektiv#942)) ([c253032](kelektiv@c253032))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@intcreator intcreator

Labels
released type:feature New feature or feature improvement & requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: drop support for Node v16 and rename job.running to job.isActive kelektiv/node-cron
2 participants
@ncb000gt @intcreator