Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot keys should be edge triggered #12

Closed
penfold42 opened this issue Oct 1, 2019 · 5 comments
Closed

Hot keys should be edge triggered #12

penfold42 opened this issue Oct 1, 2019 · 5 comments

Comments

@penfold42
Copy link
Contributor

I haven’t put the scope on it yet but holding multiple keys looks like it’s doing PWM on the outputs

@keirf
Copy link
Owner

keirf commented Oct 1, 2019

Oh I meant to fix that. But all the same given the BSRR write should match the existing pins settings, I'm surprised the output pins oscillate?

@keirf
Copy link
Owner

keirf commented Oct 1, 2019

I can't repro unstable output pins, is that due to other changes in your tree?

@keirf
Copy link
Owner

keirf commented Oct 1, 2019

Oh hang on I see what you mean: Multiple hot keys simultaneously? Why would you do that...

@keirf keirf closed this as completed in 32e05d2 Oct 1, 2019
@penfold42
Copy link
Contributor Author

Never underestimate the stupidity, or creativity, of explorative testers

@keirf
Copy link
Owner

keirf commented Oct 1, 2019

Haha, now fixed anyway :) Maybe not worth a new release in itself, as requires user to build the firmware themselves anyway, to see the problem.

My current minor annoyance is my first display of the OSD box is glitching again. That means the first time after power on, or OSD reset, that the OSD box appears (eg. Ctrl-Alt-Return) I see an instantaneous screen glitch. It does not happen again until next full reinitialisation. Can you repro that? It's very weird and I have no idea why it happens!

Glitch == Focus on immediate right of where the OSD box will appear. I find it most noticeable there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants