Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade manager should collect and expose metrics #17

Open
sandeepbhojwani opened this issue Sep 23, 2019 · 2 comments
Open

Upgrade manager should collect and expose metrics #17

sandeepbhojwani opened this issue Sep 23, 2019 · 2 comments
Assignees

Comments

@sandeepbhojwani
Copy link

Is this a BUG REPORT or FEATURE REQUEST?:
FEATURE REQUEST
What happened:

  • Upgrade manager should expose some useful metrics that can be used for monitoring, automation, etc
  • It will be best to expose the metrics in prometheus format
  • Bonus will be a grafana dashboard :)

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • rolling-upgrade-controller version
  • Kubernetes version :
$ kubectl version -o yaml

Other debugging information (if applicable):

  • RollingUpgrade status:
$ kubectl describe rollingupgrade <rollingupgrade-name>
  • controller logs:
$ kubectl logs <rolling-upgrade-controller pod>
@shaoxt
Copy link
Collaborator

shaoxt commented Apr 1, 2021

the features have been done in controller v2 #189

@sahilbadla
Copy link
Collaborator

I think there's more work that needs to be done here. According to the epic, here are the sub tasks:

  • Focus on metrics that indicate the progress of the upgrade and if it is "stuck"
  • For each CR/IG, number of nodes needed to be upgraded, number of nodes completed and number of nodes remaining. An alert could be put on non-zero values of nodes remaining not changing within a specific time period

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants