Rotation may happen on new instances

[eytan-avisror]

I noticed that when I rotate ASG nodes that were using launch configuration, to new nodes using launch templates, after all the nodes are rotated to new ones, few of the new ones also get rotated.
This seems to be related to some caching issue, because after few new nodes get rotated (needlessly), it finally gets marked as completed.

In the logs, the reason for rotation seems to be

launch template version differs	{"rollingupgrade": "rolling-upgrade-nodes-20201201234551-2"}

In this case, the instance was rotated from version 2 of the launch template to version 2.

controllers.RollingUpgrade	selected instances for rotation: [{
  AvailabilityZone: "us-west-2a",
  HealthStatus: "Healthy",
  InstanceId: "i-06c75c47f7166fcb1",
  InstanceType: "m5.large",
  LaunchTemplate: {
    LaunchTemplateId: "lt-093c21b6d6395defd",
    LaunchTemplateName: "eibissror-arktika-instance-manager-nodes-20201201234551",
    Version: "2"
  },
  LifecycleState: "InService",
  ProtectedFromScaleIn: false,
  WeightedCapacity: "1"
}]

[eytan-avisror]

After adding some debug logs, it seems we are not resolving the latest template hence comparing a digit to $Latest

launch template version differs	{"rollingupgrade": "rolling-upgrade-nodes-20201207212022-1", "instanceVersion": "1", "templateVersion": "$Latest"}