Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not fail rollout when instance dies unexpectedly #123

Open
grosser opened this issue Oct 7, 2020 · 2 comments
Open

do not fail rollout when instance dies unexpectedly #123

grosser opened this issue Oct 7, 2020 · 2 comments

Comments

@grosser
Copy link
Contributor

grosser commented Oct 7, 2020

[19:34:21] {"level"=>"error", "ts"=>1602099256.3341777, "logger"=>"controllers.RollingUpgrade", "msg"=>"Failed to runRestack", "rollingupgrade"=>"rollingupgrade-zorg-node-us-east-1c", "error"=>"Error updating instances, ErrorCount: 1, Errors: [InvalidInstanceID.NotFound: The instance ID 'i-05ec4ae16a265ef60' does not exist\n\tstatus code: 400, request id: 19b19626-88f9-41dc-8b86-b6f6377976ec]", "stacktrace"=>"github.com/go-logr/zapr.(*zapLogger).Error\n\t/go/pkg/mod/github.com/go-logr/[email protected]/zapr.go:128\ngithub.jparrowsec.cn/keikoproj/upgrade-manager/controllers.(*RollingUpgradeReconciler).error\n\t/workspace/controllers/rollingupgrade_controller.go:1202\ngithub.jparrowsec.cn/keikoproj/upgrade-manager/controllers.(*RollingUpgradeReconciler).Process\n\t/workspace/controllers/rollingupgrade_controller.go:706"}

not an urgent issue, but would be nice if instead of crashing it would retry
... simply restarted and it was fine

kubernetes: 1.19.2
keiko: 666fc9f 0.15.dev

@tekenstam
Copy link
Member

tekenstam commented Dec 4, 2020

I think this issue may be fixed by PR #138.

@uthark
Copy link
Contributor

uthark commented Dec 18, 2020

@grosser the issue should have been fixed by #138.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants